Improve B033 (duplicate set items)

PyCQA / flake8-bugbear

A plugin for Flake8 finding likely bugs and design problems in your program. Contains warnings that don't belong in pyflakes and pycodestyle.

MIT License

1.06k stars 104 forks source link

Improve B033 (duplicate set items) #385

Closed JelleZijlstra closed 1 year ago

JelleZijlstra commented 1 year ago

Include the repr() of the duplicate item in the error
Point the error directly at the duplicate item

Fixes #384

JelleZijlstra commented 1 year ago

Yes, we'll give errors for all of them. Could add a test showing that explicitly if you like.

cooperlees commented 1 year ago

Yes, we'll give errors for all of them. Could add a test showing that explicitly if you like.

Awesome. I won't block on it, so feel free to merge, but if you have time to do so, I think it clearly states the full intention and guards against regression in the future.

JelleZijlstra commented 1 year ago

Easy enough to do, I pushed the new test