Add flake8 to pre-commit config

PyCQA / flake8-bugbear

A plugin for Flake8 finding likely bugs and design problems in your program. Contains warnings that don't belong in pyflakes and pycodestyle.

MIT License

1.05k stars 103 forks source link

Add flake8 to pre-commit config #412

Closed jakkdl closed 7 months ago

jakkdl commented 10 months ago

Adding flake8 to pre-commit is a small QoL that would've saved me a CI run in #405, unless there's some recursive reason why this might be problematic. Maybe if flake8-bugbear has a bug that one's PR is fixing it could be messy, but it's not terribly difficult to pass --no-verify or temporarily disable pre-commit locally for such cases.

cooperlees commented 10 months ago

I guess we shouldn't have our own bugs ... so sure - I feel we can add away - You want to run main version and not the last released version? I'm cool either way.

r-downing commented 7 months ago

Ok to close?

cooperlees commented 7 months ago

Ya sure. Thanks again.