search

PyCQA / flake8-import-order

Flake8 plugin that checks import order against various Python Style Guides
GNU Lesser General Public License v3.0
278 stars 72 forks source link

Company imports in smarkets style or smarknexus #101

Closed janrito closed 7 years ago

janrito commented 7 years ago

Internally, we use the smarkets style, but with the addition of an import group for internal (company) pip distributed packages. Similar to what is already available for the google style, renamed appnexus.

Could we have support for application-import-names and application-package-names in either the smarkets style or a new smarknexus style?

Happy to submit a PR if this is something people are interested.

pgjones commented 7 years ago

I think it should be a new style, as the Smarkets style has no concept of application-package-names (same argument for appnexus and google). I'll welcome a pull request. I'm not convinced of the name though, what about your companies name?

janrito commented 7 years ago

Great! PR here: https://github.com/PyCQA/flake8-import-order/pull/102

janrito commented 7 years ago

Thanks @pgjones!