PyCQA / flake8-import-order

Flake8 plugin that checks import order against various Python Style Guides
GNU Lesser General Public License v3.0
278 stars 72 forks source link

Improve coverage setup in repo #129

Closed taion closed 6 years ago

taion commented 6 years ago

There are a couple of odd things with the coverage configuration here:

Also, at this point it'd probably be a bit cleaner to use pytest-cov than to invoke coverage directly.

I'd be happy to open a PR to address these if these are legitimate things worth addressing.

pgjones commented 6 years ago

I personally find the coverage metric interesting but not something to fixate on, so I'm marginal on the codecov integration. I'd happily accept a PR that improves the coverage usage though.

taion commented 6 years ago

Sure – the biggest benefit I get from using Codecov is that Codecov shows me the coverage diff from patches, so I can verify that new code added in PRs does have appropriate test coverage. See e.g. the check results for https://github.com/4Catalyzer/flask-resty/pull/129 (not super interesting because that repo is at 100% coverage and so is the patch... but then again this repo is too).

The coverage diff there is something I'm not aware that I can get easily out of using coverage tools directly, and I've found it useful in the past. Though having to tweak coverage thresholds to not make PRs undesirably go red on CI isn't fun, so I can sympathize.