search

PyCQA / flake8-import-order

Flake8 plugin that checks import order against various Python Style Guides
GNU Lesser General Public License v3.0
278 stars 72 forks source link

Warning doesn't consider duplicate imports #38

Closed djmc closed 8 years ago

djmc commented 9 years ago 
Imports statements are in the wrong order. from api.modules should be before from api.modules

I got this error because of multiple from api.modules import x, y import statements. It seems to not consider multiple lines from the same import.

mauricioabreu commented 9 years ago

I understand what you are saying but: do you think it is a flake8-import-order bug? I don't think duplicated imports should be warned by flake8-import-order because it should not be have done at all.

What is your opinion?

public commented 9 years ago

The bug hear is mostly that the error message is entirely unhelpful :)

pgjones commented 8 years ago

I think this is fixed, at least I can't reproduce something like it. Additionally https://github.com/PyCQA/flake8-import-order/blob/master/tests/test_cases/complete.py#L12 seems to be this case.