search

PyCQA / flake8-import-order

Flake8 plugin that checks import order against various Python Style Guides
GNU Lesser General Public License v3.0
278 stars 72 forks source link

Fixes symbol order in I101 error message. #45

Closed AndreLouisCaron closed 9 years ago

AndreLouisCaron commented 9 years ago

Fixes issue #44. The should_be variable was being sorted using lower-case string comparisons, which didn't match what the is_sorted() helper function checks.

public commented 9 years ago

Can you add a line to the CHANGELOG for this?

AndreLouisCaron commented 9 years ago

@public Will do. However, I just noticed this in the changelog:

0.6.1
-----

 * Fixed a bug where I101 messages were not suggesting the correct order.

I took a look at the file's history and it looks like I'm effectively reverting PR #41. I'm under the impression that this message should adapt to the import order style that's being used. Is that the case?

AndreLouisCaron commented 9 years ago

OK, I added a pair of tests for the formatting of I101 messages. I also added a new changelog entry. Lemme know if you want me to change anything!

public commented 9 years ago

Sigh. I am not good at programming sometimes.

This is great though, thanks a lot for the PR :)

ashb commented 9 years ago

:+1: Thanks for the fix! Any chance we could get this released to pypi?