search

PyCQA / flake8-import-order

Flake8 plugin that checks import order against various Python Style Guides
GNU Lesser General Public License v3.0
278 stars 72 forks source link

Support Python 2.6 #82

Closed di closed 8 years ago

di commented 8 years ago

With a few small changes, this plugin can support Python 2.6 as well.

sigmavirus24 commented 8 years ago

Flake8 3.0 does not support Python 2.6, so the py26-flake83 env will fail.

Why do you need Python 2.6 support?

di commented 8 years ago

Flake8 3.0 does not support Python 2.6, so the py26-flake83 env will fail.

Looks like it passed to me.

Why do you need Python 2.6 support?

Because I'd like to use this plugin in Python 2.6 :)

sigmavirus24 commented 8 years ago

Okay, let me ask the question differently, why can't you just run your linter on Python 2.7?

public commented 8 years ago

Py2.6 support was removed on purpose. Theoretically you should get different results on 2.6 since e.g. The stdlib is different but this is a yak I never saw fit to shave.

Running on 2.7 against 2.6 code should work fairly well. pyca/cryptography do it.

di commented 8 years ago

Fair enough! I suppose the tests are just missing those edge cases.