fix import order for from to be caseinsensitive with Google and Smarkets style

PyCQA / flake8-import-order

Flake8 plugin that checks import order against various Python Style Guides

GNU Lesser General Public License v3.0

278 stars 72 forks source link

fix import order for from to be caseinsensitive with Google and Smarkets style #95

Closed dirk-thomas closed 8 years ago

dirk-thomas commented 8 years ago

This patch resolves the problem reported in https://github.com/PyCQA/flake8-import-order/issues/80#issuecomment-254607840

The first commit adds the test which originally fails
The second commit modifies the code to make the above test pass

dirk-thomas commented 8 years ago

One remaining question: should the style imply any preference on names which are identical beside case differences? E.g. from foo import bar vs. from foo import Bar. Currently it only enforces an "unstable" sort - so any order of such two lines is valid.

dirk-thomas commented 8 years ago

Closing as a duplicate of #94. The question from this ticket is still relevant though. Also this patch uses a slightly different style (one less line wrap) if that is of any interest.