search

PyCQA / flake8-pyi

A plugin for Flake8 that provides specializations for type hinting stub files
MIT License
73 stars 23 forks source link

Fix typeshed_primer workflow #493

Closed AlexWaygood closed 5 months ago

AlexWaygood commented 5 months ago

It's been broken since we switched the workflow to use uv, because uv doesn't (by default) reinstall an editable package if it sees that it's already installed with the "right version". (I personally find this pretty surprising behaviour for editable installs. It's already tracked in https://github.com/astral-sh/uv/issues/2844.) That meant that we were just running the same version of flake8-pyi in the two runs, which meant that of course the diff between the two runs was always just 0 lines.

github-actions[bot] commented 5 months ago

This change has no effect on typeshed. 🤖🎉

AlexWaygood commented 5 months ago

It's been broken since we switched the workflow to use uv

Well, I suppose uv's behaviour must have changed at some point, since we got some typeshed_primer hits in e.g. https://github.com/PyCQA/flake8-pyi/pull/479. Anyway, explicitly passing --reinstall is more resilient.