use the standard library tomllib on sufficiently new python

PyCQA / isort

A Python utility / library to sort imports.

https://pycqa.github.io/isort/

MIT License

6.53k stars 583 forks source link

use the standard library tomllib on sufficiently new python #2202

Closed eli-schwartz closed 11 months ago

eli-schwartz commented 12 months ago

In python 3.11 it is no longer necessary to vendor (?) a toml implementation. The vendored one is now part of the standard library. Simply use that instead.

Benefits include:

micro-optimization when using the isort library API in an application that already uses tomllib, to avoid reading yet another one from on-disk
seamless support for automatically dropping tomli once the minimum python version is upgraded, via tools such as pyupgrade
distributors who patch out isort to use the system tomli, do not actually have to package tomli for versions of python that have tomllib

codecov[bot] commented 11 months ago

Codecov Report

Merging #2202 (0c20647) into main (b67a6a5) will decrease coverage by 0.07%. The diff coverage is 50.00%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2202 +/- ## ========================================== - Coverage 99.22% 99.15% -0.07% ========================================== Files 38 38 Lines 3087 3089 +2 Branches 747 748 +1 ========================================== Hits 3063 3063 - Misses 14 15 +1 - Partials 10 11 +1 ```