PyCQA / pycodestyle

Simple Python style checker in one Python file
https://pycodestyle.pycqa.org
Other
5.01k stars 755 forks source link

Missing E133 test suite and E131 in E12 test suite #293

Open TobiasRzepka opened 10 years ago

TobiasRzepka commented 10 years ago

Hi, just to mention that for E133 there's no test in the test suite and the test for E131 is located in E12.py

stchris commented 10 years ago

Not quite sure how to proceed with the E133 case, since it needs hang-closing. Trying to figure it out.

florentx commented 10 years ago

actually, the E131 test is in the E12 file because it is the same category of errors (only the number has overflowed to the next range) http://pep8.readthedocs.org/en/latest/intro.html#error-codes

For the E133 test, i haven't decided how to do it: either a standard unittest (see test_api.py), or write similar test as other codes and detect a new keyword "hang-closing", like I already detect "noeol" (see support.py).

alecklandgraf commented 8 years ago

I'm working on this one!

alecklandgraf commented 8 years ago

fixing this too: image

ashemedai commented 6 years ago

Seems the commits by @alecklandgraf should be enough to close this issue, yes?