PyCQA / pydocstyle

docstring style checker
http://pydocstyle.org
MIT License
1.11k stars 189 forks source link

Drop support for python 3.6 #539

Closed sambhav closed 3 years ago

sambhav commented 3 years ago

Thanks for submitting a PR!

Please make sure to check for the following items:

Please don't get discouraged as it may take a while to get a review.

RuRo commented 3 years ago

Sorry, but can you explain, why was this done? PEP494 seems to suggest, that Python3.6 EOL is December 2021.

sambhav commented 3 years ago

Python 3.6 has not been getting bug fixes since 3.6.8 (which was released in 2018). The latest tests were failing on 3.6 on macos. I do not want to block PRs on it and I do not have the time to put in a proper fix for such an old version of Python (released 5 years ago). I have currently staged this removal for the next major release of pydocstyle. If someone wants to fix the tests and add back support for 3.6 before the next major version is published, they are more than welcome to submit a PR with the updated GH workflow tests to add back support for 3.6.

sambhav commented 3 years ago

Created an issue to track adding back support for 3.6 in case anyone is interested in creating a PR to fix it https://github.com/PyCQA/pydocstyle/issues/540