search

PyCQA / pydocstyle

docstring style checker
http://pydocstyle.org
MIT License
1.11k stars 189 forks source link

6.3.0: incorrect version in pyproject.toml?🤔 #647

Open wuch-g2v opened 1 year ago

wuch-g2v commented 1 year ago

Looks like version in pyproject.toml is incorrect. https://github.com/PyCQA/pydocstyle/blob/07f6707e2c5612960347f7c00125620457f490a7/pyproject.toml#L3

tjanez commented 1 year ago

When I was updating the Fedora package recently, I also encountered this.

As far as I can see, the version is only set dynamically when building a release with GitHub Actions: https://github.com/PyCQA/pydocstyle/blob/07f6707e2c5612960347f7c00125620457f490a7/.github/workflows/release.yml#L30-L31 It is set to the tag name which invoked the build.

This is not very practical for the downstream rebuilds. E.g., in Fedora RPM package, I needed to implement this work-around:

sed -r -i 's/(version = ")0.0.0-dev/\1%{version}/' pyproject.toml
wuch-g2v commented 1 year ago

Why not use poetry-dynamic-versioning? 🤔