search

PyCon / pycon2019

Website for PyCon 2019
BSD 3-Clause "New" or "Revised" License
158 stars 89 forks source link

Refactor existing API views to use Django Rest Framework #391

Closed briseling closed 9 years ago

dpoirier commented 9 years ago

Question: this sounds like just an internal implementation detail. What's the expected benefit to the client?

wolever commented 9 years ago

I was linked to this issue too — is there some way I could help flesh out use cases? (although, for the very little it's worth, my gut feeling is that there wouldn't be much value in moving to DRF).

dpoirier commented 9 years ago

My gut is with yours. Although the current API implementation is entirely ad-hoc with views scattered here and there, it works well enough (or nobody has made specific complaints, anyway).

wolever commented 9 years ago

Yep. And, as far as I know, there are only a handful of people who consume the APIs, and they do it with ad-hoc scripts each year (off the top of my head: PyVideo to grab metadata about talks, myself to create session staff material, probably Luke to do program stuff, and probably Noah because IIRC he knew a bit about what was up, and possibly Felix(?) to do the mobile schedule)… so, as much as I hate to say it, there really won't be a lot of person-hours saved by improving the APIs, at least as they are used right now.

dpoirier commented 9 years ago

I think the other big user is, or has been, the proposal review team. They've used the APIs to group proposals into Thunderdome Groups and preserve IRC discussions and votes.

dpoirier commented 9 years ago

Then maybe we should just drop this? And use #392 to improve the documentation of the existing API endpoints?

wolever commented 9 years ago

Yep, that's probably going to be the best bang-for-the-buck.

Also, I haven't forgotten about the updates I owe you on the other issues. I'll be getting them some time this week.

ejodlowska commented 9 years ago

Hi @wolever - have you had a chance to provide the supplemental information?

dpoirier commented 9 years ago

Closing this per @ejodlowska and @wolever.