PyCon / pycon2019

Website for PyCon 2019
BSD 3-Clause "New" or "Revised" License
158 stars 89 forks source link

Restyle pycon website to use 2019 branding #654

Closed nlhkabu closed 6 years ago

nlhkabu commented 6 years ago

Known issues:

  1. ~Logo not showing on FF~

  2. ~Empty h1 is pushing down content~ Temporary fix pushed. See https://github.com/PyCon/pycon/issues/655 for a better fix

  3. ~password reset page~

  4. ~Check page where user resets password @ewdurbin - how can I access this in dev?~

~!!! NOTE: we need to get permission from Mike Pirnat for use of the photo on the homepage !!!~

ewdurbin commented 6 years ago

@nlhkabu I added the password reset template from pinax-theme-bootstrap to pycon/templates/account/password_reset.html for customization.

ewdurbin commented 6 years ago

My feedback:

screen shot 2018-09-13 at 8 07 17 am
nlhkabu commented 6 years ago

thanks for the feedback @ewdurbin

screenshot from 2018-09-13 20-17-41

I can't seem to reproduce the issue you are seeing on Safari - can you tell me what OS and Safari version you're using?

ewdurbin commented 6 years ago

Reproduction for that line is:

MacOS High Sierra 10.13.6 Safari 11.1.2

Widen screen above max width.

ewdurbin commented 6 years ago

Really love the improved form background!

ewdurbin commented 6 years ago

☝️ that worked.

nlhkabu commented 6 years ago

All ready on my side @ewdurbin :dancer:

As discussed, we'll probably need to look at some other pages later e.g:

But I think this is good enough for what you need right now :)

I've tested across a variety of browsers, including ie11, which is the one that tends to cause issues, and I can see no defects.

ewdurbin commented 6 years ago

Thanks for your work @nlhkabu!