PyCon / pycon2019

Website for PyCon 2019
BSD 3-Clause "New" or "Revised" License
158 stars 89 forks source link

Do not render page_title if it is empty #655

Open nlhkabu opened 6 years ago

nlhkabu commented 6 years ago

In site_base.html we have the following code:

<h1>{% block page_title %}{% endblock %}</h1>

Sometimes page_title is empty and another h1 is defined later on the page.

In this case, we do not want to render the <h1> that wraps page_title.

In the short term I have issued a temporary fix, which hides the empty h1 with css.

However, this is not ideal, as the semantics of the page are messed up.

This is a suggested fix I found: https://chase-seibert.github.io/blog/2010/10/01/check-if-a-block-is-defined-in-django.html

There is also this https://github.com/edoburu/django-capture-tag