PyDataBlog / ParallelKMeans.jl

Parallel & lightning fast implementation of available classic and contemporary variants of the KMeans clustering algorithm
MIT License
50 stars 13 forks source link

possible test failure in upcoming Julia version 1.5 #80

Closed rfourquet closed 4 years ago

rfourquet commented 4 years ago

A PkgEval run for a Julia pull request which changes the generated numbers for rand(a:b) indicates that the tests of this package might fail in Julia 1.5 (and on Julia current master branch).

Also, you might be interested in using the new StableRNGs.jl registered package, which provides guaranteed stable streams of random numbers across Julia releases.

Apologies if this is a false positive. Cf. https://github.com/JuliaCI/NanosoldierReports/blob/ab6676206b210325500b4f4619fa711f2d7429d2/pkgeval/by_hash/52c2272_vs_47c55db/logs/ParallelKMeans/1.5.0-DEV-87d2a04de3.log

Arkoniak commented 4 years ago

Yes, I've read the corresponding discussion in the discourse, and I found it quite meaningful. Thank you for bringing attention to this issue.