PyDataBlog / ParallelKMeans.jl

Parallel & lightning fast implementation of available classic and contemporary variants of the KMeans clustering algorithm
MIT License
50 stars 13 forks source link

CompatHelper: bump compat for "MLJModelInterface" to "0.4" #97

Closed github-actions[bot] closed 3 years ago

github-actions[bot] commented 3 years ago

This pull request changes the compat entry for the MLJModelInterface package from 0.2.1, 0.3 to 0.2.1, 0.3, 0.4.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

ablaom commented 3 years ago

Currently failing on Julia 1.3 only. It seems that this build pre-dates releases of MLJBase 0.17 (MLJBase is used only for testing). If you re-trigger test, the problem may disappear.

Also, I suggest you keep MLJModelInterface 0.3 as there's no reason not to - as in:

MLJModelInterface = "^0.3,^0.4"

If this doesn't fix the problem and you're stuck, ping me.

ablaom commented 3 years ago

@PyDataBlog

PyDataBlog commented 3 years ago

Currently failing on Julia 1.3 only. It seems that this build pre-dates releases of MLJBase 0.17 (MLJBase is used only for testing). If you re-trigger test, the problem may disappear.

Also, I suggest you keep MLJModelInterface 0.3 as there's no reason not to - as in:

MLJModelInterface = "^0.3,^0.4"

If this doesn't fix the problem and you're stuck, ping me.

We will look into and let you know

ablaom commented 3 years ago

@PyDataBlog Any chance of taking look at this? (See issue linked above)

PyDataBlog commented 3 years ago

@ablaom just pushed your suggested version fix. Let's see what CI says now. I will release it if it passes.

ablaom commented 3 years ago

Many thanks. Any chance of a patch release soon?

PyDataBlog commented 3 years ago

Many thanks. Any chance of a patch release soon?

I'll release it tonight since it's passing CI and needed upstream. Thanks for the heads-up