Closed ivoytov closed 1 year ago
Here is how I use the API:
params = Dict(Symbol("ex_dividend_date.gte") => "2022-12-25", :limit => 1000)
raw = stock_dividends(opts, security.ticker; params)
Here is how I use the API:
params = Dict(Symbol("ex_dividend_date.gte") => "2022-12-25", :limit => 1000) raw = stock_dividends(opts, security.ticker; params)
LGTM
Updated the test suite to make it work as well. Note for some reason I had to add TypedTables and ConfigEnv to the Project.toml file to make it compile and run.
Updated the test suite to make it work as well. Note for some reason I had to add TypedTables and ConfigEnv to the Project.toml file to make it compile and run.
Can you update the dependencies as well? Seems upstream packages have been updated a lot so package is lagging way too behind.
Ok added those 2 dependencies that were missing and rang ]update
but it didn't change anything else. From the build log it seems like the build script is failing because it's missing the API_KEY
variable. Not sure how you got it to work with your private key in the first place!
Ok added those 2 dependencies that were missing and rang
]update
but it didn't change anything else. From the build log it seems like the build script is failing because it's missing theAPI_KEY
variable. Not sure how you got it to work with your private key in the first place!
Key was working fine up until now so I guess it's because the workflow also needs updating. The API_KEY is tied to a linked secret. I will look at it tonight as well. Appreciate the updates. Feel free to join the maintenance of the package if you are up for it.
Curious if maybe the key doesn’t work since it’s running on a PR that’s not coming from you, but from my fork of the codebase.
On Jan 2, 2023, at 10:45 AM, Bernard Brenyah @.***> wrote:
Ok added those 2 dependencies that were missing and rang ]update but it didn't change anything else. From the build log it seems like the build script is failing because it's missing the API_KEY variable. Not sure how you got it to work with your private key in the first place!
Key was working fine up until now so I guess it's because the workflow also needs updating. The API_KEY is tied to a linked secret. I will look at it tonight as well. Appreciate the updates. Feel free to join the maintenance of the package if you are up for it.
— Reply to this email directly, view it on GitHub https://github.com/PyDataBlog/PolygonIO.jl/pull/21#issuecomment-1369047077, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALU6H7WAP6XL3SIE3E3YH3WQLZZRANCNFSM6AAAAAATMV2GTA. You are receiving this because you authored the thread.
I wasn't sure how to handle keyword arguments with periods in them like
ex_dividend_date.gte
so I came up with this solution.