search

PyEllips / pyElli

An open source ellipsometry analysis tool for reproducible and comprehensible building of optical models.
https://pyelli.readthedocs.io
GNU General Public License v3.0
17 stars 6 forks source link

General search in RII database #139

Closed domna closed 1 year ago

domna commented 1 year ago

I just had a look at the RII database and I thought it may be nice to have a function just called search to search in any book or page. The problem is that currently there is search_book and search_page, which users don't really know what it represents so it is hard to decide which one to use.

MarJMue commented 1 year ago

yeah the names of the functions are pretty bad. i have no good idea how to name them more verbose. As:

For inorganic and organic materials Book uses the sum formula of the compound and Page is an identifier of the author of the publication. In the case of glasses, book is the manufacturer and page the name of the glass.

Maybe you are right and we should converge all three usefull fields into one search.

domna commented 1 year ago

Yeah these book and page identifiers are pretty confusing. I never really understand where I should search in. Anyways, I think if we'd just ignore what is happening for books and pages and just search for everything then it'll be fine.