search

PyFilesystem / pyfilesystem

Python filesystem abstraction layer
http://pyfilesystem.org/
BSD 3-Clause "New" or "Revised" License
288 stars 63 forks source link

Difference between move() and rename() #230

Closed arekbulski closed 8 years ago

arekbulski commented 8 years ago

What is the difference? Is it just that rename has the destination path truncated to just the final component?

Does base class FS implement by default one by means of another?

Could anyone explain to me the semantics?

arekbulski commented 8 years ago

It is kinda sad that no one cared to even respond to this question since December. This is a basic question that should be clear after just looking at docstrings. Now I understand why I found opinions that this project is no longer maintained.

lurch commented 8 years ago

I personally try to help out on pyfilesystem here and there, but there are other open-source projects which have more of my attention currently. And it seems like the original project author @willmcgugan (who is obviously the person best placed to answer your original question) also has his focus elsewhere recently...

That doesn't mean that this project has been abandoned.

pyhedgehog commented 8 years ago

By definition this exactly means that project is abandoned: "2. No longer maintained by its former owners, residents, or caretakers."

willmcgugan commented 8 years ago

It's not abandoned.

To answer @arekbulski's original question, rename is atomic, where move may do a read / write / delete operation. You should generally use move, unless you require it to be atomic.

GitHub issues aren't the best place for questions. http://groups.google.com/group/pyfilesystem-discussion is better for that.

arekbulski commented 8 years ago

Thank you @willmcgugan ! I will put that into respective docstrings and and submit a pull request, so this issue wont come up again.

lurch commented 8 years ago

Note also the atomic.rename meta-value http://docs.pyfilesystem.org/en/latest/base.html#fs.base.FS.getmeta