sf-dlund
commented
7 years ago Thanks for the response. I actually intended to push to a forked version and forgot to change my source.
On Fri, Oct 14, 2016 at 11:29 AM, Will McGugan notifications@github.com wrote:
@willmcgugan commented on this pull request.
Sorry, I don't think this adds much. I see what you are trying to do. But often the 'original exception' isn't helpful and even misleading. Better to
store any exception object in the 'details' parameter.
In fs/errors.py https://github.com/PyFilesystem/pyfilesystem/pull/266#pullrequestreview-4290054 :
@@ -49,30 +49,31 @@ class FSError(Exception): """Base exception class for the FS module.""" default_message = "Unspecified error"
- def init(self,msg=None,details=None):
- def init(self, msg=None, details=None, originalExc=None):
Parameters should be lower_case_and_underscores
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PyFilesystem/pyfilesystem/pull/266#pullrequestreview-4290054, or mute the thread https://github.com/notifications/unsubscribe-auth/AVsXDSJ9WQslBKyKNuGGLuCzS-iWeroTks5qz5_DgaJpZM4KXHXF .
David Lund Developer SmartFile p: 877-336-3453 e: dlund@smartfile.com a: 1025 N. Senate Ave. Indianapolis, IN 46202 https://facebook.com/smartfile https://twitter.com/smartfile https://linkedin.com/company/smartfile
Updated init function to include Original Exception attribute as originalExc.
Updated individual error classes to display originalExc.
Updated convert_os_errors to pass exception type into init function for each error type.
Tested by raising various types of errors within local fs implementation.