search

PyFixate / Fixate

Framework for hardware test fixtures and automatic test environments
MIT License
22 stars 17 forks source link

Fix local pytest log checking #160

Closed John2202W closed 1 year ago

John2202W commented 2 years ago

Overwrite any potential local_config (fixate.yml) so pytests can be run locally.

Since the change in config file directories - local fixate.yml lives and persists outside the venv. This causes it to override the default logging format which the test_script2log expects. Therefore when tests are run locally they will fail when fixate.yml differs from the default.

Two possible options:

  1. Re-overwrite the fixate.yml with the default (quick/dirty solution - I have done here initially)
  2. Remove the fixate.yml as a 'global' config that is always used and instead pass it independently through the --config command line arg.

Since it is a subprocess call I don't believe we can patch something into fixate.

clint-lawrence commented 2 years ago

I think what you've implemented makes sense. Have the test control exactly what it needs and pass through as a cli option when calling fixate as a subprocess.

jcollins1983 commented 2 years ago

I think what you've implemented makes sense. Have the test control exactly what it needs and pass through as a cli option when calling fixate as a subprocess.

No objections to me merging this PR then? Looks good to me.