Fix driver import errors

PyFixate / Fixate

Framework for hardware test fixtures and automatic test environments

MIT License

22 stars 16 forks source link

Fix driver import errors #161

Closed John2202W closed 1 year ago

John2202W commented 2 years ago

Now catch the pyvisa exception when a driver cannot be opened and raise a more informative error message on top.

Previous:

pyvisa.errors.VisaIOError: VI_ERROR_RSRC_NFOUND (-1073807343): Insufficient location information or the requested device or resource is not present in the system.
New:

fixate.drivers.InstrumentOpenError: Unable to open DSO: USB0::0x2A8D::0x1797::CN58166436::INSTR

Fixed circular import in pps driver. Remove a missed old pyvisa import from pytests (don't believe it is run atm anyway)

John2202W commented 1 year ago

@jcollins1983 - if you are doing some fixate reviews (this may impact changes to the DMM init in PR #162 aswell) - would be good to get this one in the pipeline. Giving info on the failed driver would help production out a whole heap instead of pyvisa error xxxxx, they can at least try re-plugging or cycling power on the relevant instrument.

John2202W commented 1 year ago

There's a couple of comments that could do with an update as indicated. There are a few "dittos" because of the copy/paste nature of these drivers. I feel like there's a better way, anyway, not the point of this review. Once you've fixed up those comments I'll be happy to merge.

I think a generic "visa instrument" helper would be super useful - have discussed this in the past that specific drivers can inherit and prevent all the duplicated visa related setups/controls.