Closed josh-marshall-amp closed 3 months ago
tl;dr — ruff
I also added ruff-pre-commit
to the hooks, but it made far too many changes across the codebase. And a lot of the samples have unused includes, but it's because they are likely to be used etc.
A thought I had is that I could have it installed locally via pre-commit but not in the repo checks, for now at least.
If you want to try it, I was using: (note version is much updated from our other repos, it was at 0.0.28!)
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.5.4
hooks:
- id: ruff
args: [--fix, --exit-non-zero-on-fix]
Closed in lieu of https://github.com/PyFixate/Fixate/pull/199 which doesn't have all the back-and-forth history garbage.
These are the actual changes from adding pre-commit and doing an
--all-files
run.I spotted this because @jcollins1983 was calling me out for corrections that black should have done and me thinking "but I have pre-commit" running.