search

PyImageSearch / imutils

A series of convenience functions to make basic image processing operations such as translation, rotation, resizing, skeletonization, and displaying Matplotlib images easier with OpenCV and Python.
MIT License
4.51k stars 1.03k forks source link

Changing 'angle' in rotate_bound() from negative to positive to unify… #263

Closed IgorZaton closed 2 years ago

IgorZaton commented 2 years ago

… it with rotate() funciton.

Since definition of rotation matrix around specific axis is that the positive angle is counter clockwise rotation, I guess it should be like this in rotate_bound() function. Additionally consider that in rotate() function angle is counter clockwise, so making it the same in rotate_bound() would unify the library.

ariG23498 commented 2 years ago

Hey @IgorZaton

This is a fine suggestion. We will look into it later, but at the moment we will not be merge this as this is not a bug or a fix to it.