search

PyJaipur / PyJudge

Simple Programming Contest hosting software
MIT License
17 stars 29 forks source link

Clean up HTML and CSS #70

Closed theSage21 closed 5 years ago

theSage21 commented 5 years ago

The html in index.html has some CSS classes which are note being used. We need to clean it up. that file also has lots of inline style code. That has to be removed.

MattMski commented 5 years ago

I would like to contribute if possible

theSage21 commented 5 years ago

Sure! Please ask for help here if you need it.

On Mon 28 Jan, 2019, 08:59 Matthew <notifications@github.com wrote:

I would like to contribute if possible

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PyJaipur/PyJudge/issues/70#issuecomment-457988774, or mute the thread https://github.com/notifications/unsubscribe-auth/AHVj0ViClqZHPPQ2LALoJsF7IVPmESpuks5vHm6dgaJpZM4aUuA_ .

MattMski commented 5 years ago

Yea I am pretty new to contribution and this is for a university project. So far I've forked and cloned the project. Is there anything else I should know? Should i submit changes to the master branch or another other branch?

theSage21 commented 5 years ago

Changes have to be submitted to the master branch. Your master to our master

On Mon 28 Jan, 2019, 09:21 Matthew <notifications@github.com wrote:

Yea I am pretty new to contribution and this is for a university project. So far I've forked and cloned the project. Is there anything else I should know? Should i submit changes to the master branch or another other branch?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PyJaipur/PyJudge/issues/70#issuecomment-457991575, or mute the thread https://github.com/notifications/unsubscribe-auth/AHVj0bCw6eDQs3Vjs7RtFoLbVX1TlOTOks5vHnPLgaJpZM4aUuA_ .

MattMski commented 5 years ago

Alright

gauravrock commented 5 years ago

The html in index.html has some CSS classes which are note being used. We need to clean it up. that file also has lots of inline style code. That has to be removed.

@theSage21 all the inline style code is to be removed ..is it?? There are 5 places where the inline style is used in index.html!!!

theSage21 commented 5 years ago

Since we are using separate CSS files we can remove the inline styles.

On Mon 28 Jan, 2019, 20:56 Gaurav sharma <notifications@github.com wrote:

The html in index.html has some CSS classes which are note being used. We need to clean it up. that file also has lots of inline style code. That has to be removed.

@theSage21 https://github.com/theSage21 all the inline style code is to be removed ..is it?? There are 5 places where the inline style is used in index.html!!!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PyJaipur/PyJudge/issues/70#issuecomment-458174623, or mute the thread https://github.com/notifications/unsubscribe-auth/AHVj0VuBldjPvQwBoTd-0RrXSurI6EQ7ks5vHxaMgaJpZM4aUuA_ .

Priyanka-ashok commented 5 years ago

Can i take the issue and work on it ?

shivankgtm commented 5 years ago

sure @Priyanka-ashok. feel free to ask here if you have any doubt. you can also join the telegram group mentioned in README.md for general purpose.

HeroicHitesh commented 5 years ago

Is this issue resolved or something is needed to be done?

theSage21 commented 5 years ago

it's open. A related merge request is there so I suggest that you take a look at that and see what discussion happened there.

HeroicHitesh commented 5 years ago

it's open. A related merge request is there so I suggest that you take a look at that and see what discussion happened there.

I reviewed #74 and except 1 change everything seems to be fine. I don't understand why it is not changed and merged till now.

theSage21 commented 5 years ago

The way CSS is what I wanted to improve. No issues. I'll merge when I get a chance

On Sun 10 Feb, 2019, 19:52 HeroicHitesh <notifications@github.com wrote:

it's open. A related merge request is there so I suggest that you take a look at that and see what discussion happened there.

I reviewed #74 https://github.com/PyJaipur/PyJudge/pull/74 and except 1 change everything seems to be fine. I don't understand why it is not changed and merged till now.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PyJaipur/PyJudge/issues/70#issuecomment-462136923, or mute the thread https://github.com/notifications/unsubscribe-auth/AHVj0bySLq3fC-RLjVZVB8262KwnhpZpks5vMCshgaJpZM4aUuA_ .

MattMski commented 5 years ago

Would it be okay to merge both css files so it's just one css with everything?

theSage21 commented 5 years ago

Definitely! But only if the CSS is used in both html files. Otherwise just move the common content to one file and keep the unique content in a style tag

On Tue 19 Feb, 2019, 01:10 Matthew <notifications@github.com wrote:

Would it be okay to merge both css files so it's just one css with everything?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PyJaipur/PyJudge/issues/70#issuecomment-464853924, or mute the thread https://github.com/notifications/unsubscribe-auth/AHVj0dqBcjwOcUpLWz39wvZ9GDngQcGUks5vOwGTgaJpZM4aUuA_ .

HeroicHitesh commented 5 years ago

Definitely! But only if the CSS is used in both html files. Otherwise just move the common content to one file and keep the unique content in a style tag … On Tue 19 Feb, 2019, 01:10 Matthew @.*** wrote: Would it be okay to merge both css files so it's just one css with everything? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#70 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AHVj0dqBcjwOcUpLWz39wvZ9GDngQcGUks5vOwGTgaJpZM4aUuA_ .

Maybe we can use html and css which is common in all html and css files in 1 base.html template using inline styling or do we need to do it in 2 different template files 1 for html and 1 for css?

theSage21 commented 5 years ago

That is a matter of taste. I usually put it in a separate file so that other people can work on CSS separately and the PRs don't create merge conflicts.

MattMski commented 5 years ago

Well I'm a CS student and I feel that would be better for organization. I'll merge the css files, obviously the unique stuff for each html file will work as well, I will make that work, don't worry. In the end, having a clean HTML file is good and a CSS file to control all the looks.

theSage21 commented 5 years ago

Sure! Go ahead!

adityabohra007 commented 5 years ago

In index.html there is an anchor to the "here" that is href="#"

theSage21 commented 5 years ago

Are you referring to this line?

That is a placeholder. When we have something we will put it there. At least that's what it looks like.

A better person to ask would be the person who wrote that. From the Blame window it looks like @rustagishubhi is the one who can answer that

rustagishubhi commented 5 years ago

@adityabohra007 you can replace the # with the link where the criterias are mentioned

ShumailAhmed123 commented 5 years ago

Hi,

Can I contribute to this project? Is there any other issues related to HTML and CSS. I am happy to work on them.

Please let me know.

Thanks

theSage21 commented 5 years ago

Take a look at the issues

On Wed 13 Mar, 2019, 18:00 ShumailAhmed123, notifications@github.com wrote:

Hi,

Can I contribute to this project? Is there any other issues related to HTML and CSS. I am happy to work on them.

Please let me know.

Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PyJaipur/PyJudge/issues/70#issuecomment-472402443, or mute the thread https://github.com/notifications/unsubscribe-auth/AHVj0b2DVZcZKOzy-8-E920YG9N2-y8Qks5vWO94gaJpZM4aUuA_ .

ShumailAhmed123 commented 5 years ago

Hi, @theSage21 When I click on the link. I get this error.

"Whoops! That unsubscribe link isn't valid for your account."

Thanks

theSage21 commented 5 years ago

I'm not sure what link you are clicking on.

Go to the github repo. Look at the issues. If I'm not wrong your typing this in an issue right now.

Look at the discussion there and open a pull request with your changes in it.

If you want to clarify something, read the Readme of the project and if that does not answer your questions type it in the issue here

On Wed 13 Mar, 2019, 18:36 ShumailAhmed123, notifications@github.com wrote:

Hi, @theSage21 https://github.com/theSage21 When I click on the link. I get this error.

"Whoops! That unsubscribe link isn't valid for your account."

Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PyJaipur/PyJudge/issues/70#issuecomment-472413983, or mute the thread https://github.com/notifications/unsubscribe-auth/AHVj0dkHJWMmR8BB9LxymZ1Wxv6YFXSjks5vWPftgaJpZM4aUuA_ .

theSage21 commented 5 years ago

oh now it makes sense. you wanted some other HTML stuff.

62 #30 and #59 are all related to HTML CSS

MattMski commented 5 years ago

Is there any other html/css related stuff I could work on?

theSage21 commented 5 years ago

you mean besides the issues that are already open?

MattMski commented 5 years ago

Yeah