search

PyJaipur / SoA

Website for summer of algorithms
https://soa.pyjaipur.org/
9 stars 10 forks source link

OTP issues #29

Closed shivankgtm closed 4 years ago

shivankgtm commented 4 years ago

OTP link come as https://soa.pyjaipur.org/otp?q=xxxxxxxxxxxxxxxxxxxxxxxxxxxx from the heroku link of SoA. soa.pyjaupur is still there. should it be like that or pyjaipur-soa.herokuapp.com also both OTPs doesn't work.

theSage21 commented 4 years ago

Thanks for the catch @Shivank98

Our current architecture is a little strange and this was a result of that.

  1. We maintain a netlify app from the netlify branch of this project which specifies a redirect from soa.pyjaipur.org to our heroku app.
  2. This way we can maintain full HTTPS without any costs
  3. The domain redirect, however, strips the query parameters while redirecting. That's why we were losing the otp tokens.

The link in the email is generated using the env variable BASE_DOMAIN. I've corrected this in our app and otps should now work normally.

shivankgtm commented 4 years ago

Looks good. I missed that.