search

PyJaipur / SoA

Website for summer of algorithms
https://soa.pyjaipur.org/
9 stars 10 forks source link

removed shivank folder, changes env to .env( as per Makefile), updated readme #33

Closed shivankgtm closed 4 years ago

shivankgtm commented 4 years ago

Umm, don't know why this much commits are coming. I rebased the repo

theSage21 commented 4 years ago

You probably rebased on top of your own master. You need to either rebase on top of pyj/master or sync your master to pyj/master and then rebase on origin/master.

shivankgtm commented 4 years ago

Are you sure you wanted to delete the default env file?

No I didn't deleted that. I changed to .env from env as in makefile it was .env.

shivankgtm commented 4 years ago

You probably rebased on top of your own master. You need to either rebase on top of pyj/master or sync your master to pyj/master and then rebase on origin/master.

Ohh, ok

shivankgtm commented 4 years ago

Also, our website works fine. do we even need this PR? I made this because I was facing some errors due to makefile not being able to identify .env. but that might be due to my mistake in a symlink.

theSage21 commented 4 years ago

Your synonyms might need to be re-setup. I fixed the theme.html thing on master so that change is no longer needed.

On Mon 4 May, 2020, 13:59 Shivank Gautam, notifications@github.com wrote:

Also, our website works fine. do we even need this PR? I made this because I was facing some errors due to makefile not being able to identify .env. but that might be due to my mistake in a symlink.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/PyJaipur/SoA/pull/33#issuecomment-623329857, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2WHUOFX6RHRHVNYA6WBMLRPZ4G5ANCNFSM4MYQ6NCQ .

theSage21 commented 4 years ago

*symlinks

On Mon 4 May, 2020, 14:03 Arjoonn, arjoonn.94@gmail.com wrote:

Your synonyms might need to be re-setup. I fixed the theme.html thing on master so that change is no longer needed.

On Mon 4 May, 2020, 13:59 Shivank Gautam, notifications@github.com wrote:

Also, our website works fine. do we even need this PR? I made this because I was facing some errors due to makefile not being able to identify .env. but that might be due to my mistake in a symlink.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/PyJaipur/SoA/pull/33#issuecomment-623329857, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2WHUOFX6RHRHVNYA6WBMLRPZ4G5ANCNFSM4MYQ6NCQ .

shivankgtm commented 4 years ago

Right, closing this PR.