Closed encukou closed 2 years ago
Thank you for all those necessary changes. I did try to run Zpetnovazebnik as it is now and experienced all those problems addressed in the commits. The current setup works like charm. What I checked:
Django50DeprecationWarnings
in the current version - all addressed in this PR, tests run without issuesThe migration plan sounds good. How long will the app be down? When will you have time to perform the migration?
Thanks!
Switching the database should take a few minutes. I don't know how long it'll take to set up the redirection -- I've never done that. I don't think it'll be more than an hour.
I could do it today, or Monday. Whatever is OK with you (as you run the only currently active course).
Good point. I'll merge after the site is in maintenance mode. I updated the list above. Starting now.
One more thing I did is set branch protection for the old master
branch. It now requires the maximum of 6 reviews, so hopefully no one will merge to it (which might still trigger something, maybe).
Heroku will stop free hosting soon (#50), so this app needs an update. This PR has a few more updates than strictly necessary – see individual commits.
My branch is now deployed with rosti.cz at https://zpetnovazebnik.pyladies.cz/ with a slightly modified copy of the data, which will be discarded later. Your password should work there, so feel free to test things out (but be sure you're not on messing with the „live” app at herokuapp.com).
Heroku deploys automatically from
master
, but this PR is for themain
branch so merging this shouldn't break Heroku. The plan is:main
as the default branchrosti
to pull from this repo (but note that deployment there is not automatic like with Heroku).