mrava87 commented 2 years ago

Motivation

The pylops.waveeqprocessing.Kirchhoff operator has gone through a major restyling in https://github.com/PyLops/pylops/pull/431 mostly aimed at including dynamic capabilities. From the discussions in the https://github.com/PyLops/pylops/pull/431 and https://github.com/PyLops/pylops/pull/418 we have identified the following areas that may need further improvement. Moreover some of the new features in such PR are so far only available for the 2D implementation.

Features to be implemented

[ ] Add 2.5D wavelet filtering in _wavelet_reshaping. Current roadblock is represented by the unclear definition of σ_S and σ_R in equation 2.3.7 of Safron2018 (neither in the Bleistein and Gray, 2002 paper).
[ ] Devise a new definition of aperture not simply based on the offset/depth ratio to be used for heterogeneous velocity models. Currently we raise a warning when a user decides to activate such aperture limitation
[x] ~~Finalize discussion about the role of snell, and if this is actually needed at all.~~
[ ] Finalize discussion about angle scaling and introduce cospower as discussed in the PR
[x] ~~Implement angle scaling with normal (instead of vertical) when anglerefl is provided~~
[ ] Implement all features when dynamic=True in 3D

mrava87 commented 2 years ago

dikwickley commented 1 year ago

hello @mrava87 @cako i would like to work on this issue. can you please assign it to me?

mrava87 commented 1 year ago

Sure! get in touch with us (@cako) on slack so we can discuss better maybe where it is better to start :)