Basic operators from functions to classes

PyLops / pylops

PyLops – A Linear-Operator Library for Python

https://pylops.readthedocs.io

GNU Lesser General Public License v3.0

431 stars 102 forks source link

Basic operators from functions to classes #496

Closed rohanbabbar04 closed 1 year ago

rohanbabbar04 commented 1 year ago

Fixes #330

Updated Block, _Block, Gradient, FirstDirectionalDerivative, SecondDirectionalDerivative, Smoothing1D , Smoothing2D, Laplacian and LinearRegression
Also made Convolve2D a class as Convolve1D and ConvolveND were classes.

rohanbabbar04 commented 1 year ago

Wanted to know if this what needs to be done for classes Laplacian,FirstDirectionalDerivative and SecondDirectionalDerivative as these depend on other operators?

mrava87 commented 1 year ago

Let me take a look once you have taken into account @cako’s comments

rohanbabbar04 commented 1 year ago

Thank You @cako for reviewing my PR. I have made the changes, do review them.

mrava87 commented 1 year ago

Alright, I agree this looks great :)

Once you have included @cako's comment and we have merged https://github.com/PyLops/pylops/pull/489, I think we can also merge this PR

cako commented 1 year ago

Looks good to me, very well done! I'll let @mrava87 have a final look and merge.