search

PyMoDAQ / pymodaq_plugins_template

Template fro PyMoDAQ's plugin packaging
MIT License
3 stars 31 forks source link

Most recent version of template requires not yet published pymodaq #8

Closed BenediktBurger closed 9 months ago

BenediktBurger commented 9 months ago

This line: https://github.com/PyMoDAQ/pymodaq_plugins_template/blob/d1769557ab065a86361282405d56e6aac7658ab6/setup.py#L1

requires a version of pymodaq, which is not yet published. Therefore, all plugins, which use this line cannot be installed, unless the user has also the most recent (github version) of pymodaq.

I suggest to include it in a try except clause:

try:
    import ...
except ModuleNotFoundError:
   # define it manually

EDIT: I've noticed, that the default pymodaq version required is 4.1, so both fit together.

seb5g commented 9 months ago

Yes I published the required version yesterday so it should be fine. Should we close this?