search

PyMoDAQ / pymodaq_plugins_thorlabs

Set of PyMoDAQ plugins for instruments from Thorlabs (Kinesis K10CR1 (stepper rotation actuator), Kinesis Flipper, Kinesis KSP100...)
MIT License
3 stars 27 forks source link

Force pylablib version to 1.4.1 #17

Closed rgeneaux closed 11 months ago

rgeneaux commented 11 months ago

Hi, We've found out that the last pylablib version (1.4.2) throws a bug at initialization of Thorlabs TSI cameras. So I'd like to stay with 1.4.1 for now - is that ok with the color features you added?

seb5g commented 11 months ago

well the guy from pylablib told be the new release is actually taking care of camera colors and debayering process in case of color camera. So I wanted to move into using it but I could not test it so far, what's the issue you're talking about. Did you raise an issue on pylablib?

rgeneaux commented 11 months ago

No I need to write a minimal test outside of pymodaq to verify which functions throws errors (looks like there are several, happening when you initialize the controller).

rgeneaux commented 11 months ago

Issue raised on pylablib here: https://github.com/AlexShkarin/pyLabLib/issues/65

seb5g commented 11 months ago

well the problem is that version 1.4.2 introduces many new instruments and I've been using the Keithley2110. So forcing version 1.4.1 would be an issue for people who want to use these new ones. Can't we patch the TLCameras object within our plugin to get it working while pylablib publishes a correction?

rgeneaux commented 11 months ago

I tried to understand the error but I didn't succeed, it's a bit cryptic..

seb5g commented 11 months ago

did the guy replied?

rgeneaux commented 11 months ago

not yet!

seb5g commented 11 months ago

don't know what to do...

rgeneaux commented 11 months ago

I'd say the priority is that whatever is on pypi is stable. Even at the cost of more functionality. So until the PR is solved on pylablib, I think we force the plugin to pylablib==1.4.1 on the pypi version, and create another branch here that works in 1.4.2, so that users that know a bit more what they're doing can use it

seb5g commented 11 months ago

ok but you have to let us now when your issue has been replied by pylablib