Initial fix of the 'UC480_Camera' object has no attribute 'exposure' …

PyMoDAQ / pymodaq_plugins_thorlabs

Set of PyMoDAQ plugins for instruments from Thorlabs (Kinesis K10CR1 (stepper rotation actuator), Kinesis Flipper, Kinesis KSP100...)

MIT License

3 stars 27 forks source link

Initial fix of the 'UC480_Camera' object has no attribute 'exposure' … #5

Closed LMSC-NTappy closed 2 years ago

LMSC-NTappy commented 2 years ago

See issue #4. On my side everything works like this (only tested with a single DCC1545M) but if someone could check on their side it's appreciated. I think the root cause of the issue was that the plugin was written for an old version of instrumental (0.3 or 0.4 maybe?) and that the parameter exposure is deprecated now.

[x] No more error upon initalizing camera
[x] Add control of camera gain,
[ ] ~~Add control of Pixel Clock~~
[ ] ~~Add exposure range update upon changing pixel clock~~
[ ] ~~Add possibly other controls~~

LMSC-NTappy commented 2 years ago

Ok, in the mean time I have become aware of mabuchilab/Instrumental#144 and I think there are other faulty behaviours in the instrumental UC480 library (see mabuchilab/Instrumental#150).

Currently this limits the control I am able to bring to the camera though... I can only provide gain and exposure. It is enough to make it useful though...

So in my opinion, the way to go would be to release this patch in the current form for the plugin library and wait until the instrumental library gets fixed before implementing enhancement (or changing from package).

Let me know how to proceed from here.

quantumm commented 2 years ago

I just tested with a DCC3240M camera and it works perfectly. Good job ;)

@seb5g It would be nice to specify the installation of the 0.6 version of instrumental-lib. I guess this should be done in the plugin_info.toml file. Is it enough to write "instrumental-lib==0.6"? Otherwise i do not have access to the repository so you have to merge.