PyO3 / maturin-action

GitHub Action to install and run a custom maturin command with built-in support for cross compilation
MIT License
127 stars 35 forks source link

Publishing failed on Windows #224

Closed djc closed 10 months ago

djc commented 11 months ago

I am publishing releases from GitHub Actions using this action, but today it failed to find any interpreters on Windows:

https://github.com/instant-labs/instant-segment/actions/runs/6654425271

Any suggestions why that might be?

messense commented 11 months ago

Try upgrade maturin to latest version first

https://github.com/instant-labs/instant-segment/blob/e2771b776a49dc7b1faf5e35e322a3b19083de83/instant-segment-py/pyproject.toml#L2

py.exe on Windows did a breaking change in Python 3.11 which breaks old version of maturin, see https://github.com/PyO3/maturin/issues/1221.

djc commented 10 months ago

Okay, I've done this, but I'm running into other failures now. For example, while I would expect the working-directory argument to be relative to the checkout root, it seems to be relative to the current working dir?

I currently have https://github.com/instant-labs/instant-segment/pull/47 but this fails with pretty strange issues:

https://github.com/instant-labs/instant-segment/actions/runs/6800422246/job/18489112119

messense commented 10 months ago

Not sure what you mean, but the upload job doens't checkout the git repo so there is no instant-segment-py folder. I think you can simply remove workding-directory from upload job because download-artifact action puts everything in cwd by default.

djc commented 10 months ago

Okay, I finally managed to straighten out all the issues. Thanks for the support.