PyO3 / maturin-action

GitHub Action to install and run a custom maturin command with built-in support for cross compilation
MIT License
123 stars 31 forks source link

Args passing to runner incorrectly #227

Open npapapietro opened 7 months ago

npapapietro commented 7 months ago

I'm attempting to run a testpypi in my CI with the following workflow job step:

    - name: Publish to PyPI
      uses: PyO3/maturin-action@v1
      env:
        MATURIN_PYPI_TOKEN: ${{ secrets.PYPI_TOKEN_TEST }}
      with:
        command: upload
        args: "-r testpypi --skip-existing dist/*"

And the job runs via

/home/runner/work/_temp/01b59811-e59d-4b85-a41e-ca41aefcbc6d/maturin upload --repository --skip-existing ...

Where the arg for -r/--repository is removed. I've used the environment var MATURIN_REPOSITORY to work around for now.

Here is the job that attempted to run https://github.com/npapapietro/liesym/actions/runs/6828779586/job/18573598558 if you'd like to further inspect

ojii commented 5 months ago

Had the same issue with --repository-url ..., but was able to work around this issue by using --repository-url=...

Dan-wanna-M commented 1 week ago

Had the same issue with --repository-url ..., but was able to work around this issue by using --repository-url=...

I second this, I have been fiddling with multiple features for two hours and --features="xxx xxx xxx" seems to be the only correct method