PyO3 / maturin-action

GitHub Action to install and run a custom maturin command with built-in support for cross compilation
MIT License
127 stars 35 forks source link

actions/upload-artifact@v4 #238

Closed elasticdotventures closed 9 months ago

elasticdotventures commented 9 months ago

Just a heads up that github actions upload-artifact@v4 does not allow multiple artifacts with the same name.

I think @v3 is generated by maturin generate-ci github .. not sure how long that will continue to work, just posting this here for anybody who runs across the same issue.

the docs relevant section is:

_

Due to how Artifacts are created in this new version, it is no longer possible to upload to the same named Artifact multiple times. You must either split the uploads into multiple Artifacts with different names, or only upload once. Otherwise you will encounter an error.

_

messense commented 9 months ago

See https://github.com/PyO3/maturin/pull/1886