search

PyO3 / maturin-action

GitHub Action to install and run a custom maturin command with built-in support for cross compilation
MIT License
132 stars 37 forks source link

Remove `CARGO_HOME` from docker env var #262

Closed dariocurr closed 6 months ago

dariocurr commented 6 months ago

Hi, I'm Dario.

Using this action, I encountered a strange error. Then I realized that the problem was that I had set the CARGO_HOME environment variable in a previous step and that this variable was passed as -e argument to the docker run command. So, when trying to use the rustup command the wrong PATH was used instead of the immediately previous one installed.

I believe this is a dangerous misconfiguration that may lead to an unusable action for some users. For this reason I would explicitly exclude some variables such as CARGO_HOME that should not be passed.

dariocurr commented 6 months ago

Since https://github.com/dtolnay/rust-toolchain/pull/108 got merged, I guess this PR is very useful