PyO3 / maturin-action

GitHub Action to install and run a custom maturin command with built-in support for cross compilation
MIT License
123 stars 31 forks source link

How does the action handle globs? #270

Open max-sixty opened 3 weeks ago

max-sixty commented 3 weeks ago

We're attempting to upload lots of files. We're passing in a glob here: https://github.com/PRQL/prql/pull/4568/files#diff-e426ed45842837026e10e66af23d9c7077e89eacbe6958ce7cb991130ad05adaR319-R329

That glob correctly picks up the files when in a normal run:, from https://github.com/PRQL/prql/actions/runs/9439404299/job/25997680563?pr=4568:

Run ls -al ./**/*{.whl,.tar.gz}
-rw-r--r-- 1 runner docker 3774516 Jun  9 21:12 ./prqlc-python-Linux-aarch64-release/prqlc-0.12.2-cp37-abi3-manylinux_2_17_aarch64.manylinux2014_aarch64.whl
-rw-r--r-- 1 runner docker  473007 Jun  9 21:12 ./prqlc-python-Linux-source-release/prqlc-0.12.2.tar.gz
-rw-r--r-- 1 runner docker 3839943 Jun  9 21:12 ./prqlc-python-Linux-x86_64-release/prqlc-0.12.2-cp37-abi3-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
-rw-r--r-- 1 runner docker 2363447 Jun  9 21:12 ./prqlc-python-Windows-x86_64-release/prqlc-0.12.2-cp37-abi3-win_amd64.whl
-rw-r--r-- 1 runner docker 5637885 Jun  9 21:12 ./prqlc-python-macOS-universal2-apple-darwin-release/prqlc-0.12.2-cp37-abi3-macosx_10_12_x86_64.macosx_11_0_arm64.macosx_10_12_universal2.whl

But not when passed as part of the maturin action:


/home/runner/work/_temp/d51478de-84b8-43c8-aab6-741bdae0aeb9/maturin upload --skip-existing
⚠️  Warning: No files given, exiting.

When a pure * was passed as the glob, the action did pick up lots of files (but attempted to upload a directory, which didn't work): https://github.com/PRQL/prql/actions/runs/9432185880/job/25981724946

...so is there something idiosyncratic about how this action handles globs?

Ref https://github.com/PRQL/prql/pull/4563 & https://github.com/PRQL/prql/pull/4568

Thank you!