Closed programmerjake closed 3 years ago
Related to #367
An alternative option is to just default to manylinux2014 for supported platforms (otherwise it defaults to off) and people have to explicitly use --manylinux=2010
when they really need support for such an old OS.
Sounds like a good idea! Implementation-wise, the manylinux could have an auto
value that takes the lowest value currently supported. (It would be even better if we could take the lowest version the built binary supports, but unfortunately I haven't figured out how to port that auditwheel part that checks what glibc version is linked to rust)
Bitten by this in https://github.com/messense/maturin/runs/1915790218?check_suite_focus=true , it happily builds maturin-0.9.1-py3-none-manylinux2010_aarch64.whl
but aarch64 wheel only works on manylinux2014 and later. We should have a better default version.
Fixed by #424
I encountered an issue with manylinux support for architectures not included in manylinux2010 (powerpc64le-unknown-linux-gnu for me): Maturin's argument parsing defaults to manylinux2010, which causes pip to not be able to install the built wheel:
What do you think of refactoring argument parsing to pick the default manylinux version based on the target arch? something like this: