PyO3 / maturin

Build and publish crates with pyo3, cffi and uniffi bindings as well as rust binaries as python packages
https://maturin.rs
Apache License 2.0
3.93k stars 272 forks source link

Docker and nightly #413

Closed hwchen closed 3 years ago

hwchen commented 3 years ago

Please provide the following information:

Please list the exact steps required to reproduce your error with all command output and if possible with a repository:

In github actions:

Does using the docker image support nightly? From the Dockerfile it looks like the image installs its own rustc and toolchain, so the separate install of the nightly toolchain is useless.

konstin commented 3 years ago

I've added some more information to the readme (https://github.com/PyO3/maturin/commit/9f95d0af69291ab0811380f92bcb971d0c96cba8#diff-1550ec65ac92f65817fc28928dfef526912b5f52356ff43651369bae92f56031). The problem is essentially that the image I can provide rather is really limited, so I've added instructions to build your own setup. Could you check if that works for you?

hwchen commented 3 years ago

Thanks, this is super helpful! I’ll try this out soon, the examples look pretty straightforward.

hwchen commented 3 years ago

Thanks again. I got the Github action to work, just wanted to leave some notes here in case anybody needs to also access private repos during the build:

 create_wheels_manylinux:
    name: Create wheels for manylinux
    runs-on: ubuntu-latest
    container: quay.io/pypa/manylinux2014_x86_64
    steps:
      - name: Checkout repository
        uses: actions/checkout@v1

      - run: yum update && yum install -y openssh openssh-clients

      - uses: webfactory/ssh-agent@85353917a25aa1f197c5dff70d3ab6ef5aa88cd4
        with:
          ssh-private-key: ${{ secrets.SQLPARSER_PRIVATE_KEY }}