search

PyO3 / pyo3

Rust bindings for the Python interpreter
https://pyo3.rs
Apache License 2.0
12.06k stars 744 forks source link

remove internal APIs from pyo3-ffi #4201

Closed Cheukting closed 3 months ago

Cheukting commented 4 months ago

Using methods from PyAny to replace calling _Py internal APIS from pyo3-ffi.

see #3762

alex commented 4 months ago

Looks like CI is failing due to a warning from an unused macro.

Cheukting commented 4 months ago

Sure, this PR is still WIP. I will work on it more soon.

Cheukting commented 4 months ago

@davidhewitt happy to do it either here or open a new PR for the suggestion

davidhewitt commented 4 months ago

Given this PR is still relatively self-contained, I'd be happy for the additional changes to be pushed here 👍

adamreichold commented 4 months ago

@Cheukting Could you have a look into the build error on GraalPy from our CI? If you'd like, we can also label this PR so the cull CI suite is run on every push so you do not have to wait for the merge queue to validate your changes?

Cheukting commented 3 months ago

@adamreichold it is due to an unused import it seems: https://github.com/PyO3/pyo3/actions/runs/9336538447/job/25697227447#step:10:132

I will have a look into it, thanks!

Cheukting commented 3 months ago

@adamreichold do you mind running the check on the merge queue again to see if my fix works?