make datetime from timestamp tests compare against Python result

PyO3 / pyo3

Rust bindings for the Python interpreter

https://pyo3.rs

Other

11.44k stars 693 forks source link

make datetime from timestamp tests compare against Python result #4275

Closed davidhewitt closed 1 week ago

davidhewitt commented 1 week ago

Based off #4212, includes the commits from @Cheukting

The observation is that I believe these tests are trying to verify the Rust behaviour (via the datetime bindings in PyO3) matches the Python behaviour.

So if the call throws, it doesn't matter, as long as the Python call would also throw.

Closes #4212 Closes #3922

davidhewitt commented 1 week ago

As a test adjustment, will proceed to merge this now without waiting for review.