search

PyO3 / pyo3

Rust bindings for the Python interpreter
https://pyo3.rs
Other
11.44k stars 693 forks source link

fixes #4285 -- allow full-path to pymodule with nested declarative modules #4288

Open alex opened 1 week ago

alex commented 6 days ago

Hmm, how would expanding the macros eagerly work? Handling the variety of different forms a user can write this in is... expansive. (A user can use pyo3::prelude as foo; which this PR obviously doesn't handle.)

alex commented 19 hours ago

Are there other pieces you'd like here besides expanding to pyfunction/pyclass?

davidhewitt commented 18 hours ago

I think that's just it, I see you solved the Path complication above 👍

The eager expansion / unlimited forms of use imports can be problems for the future.

alex commented 18 hours ago

Will add support for those after work today. Thanks for the review

On Tue, Jul 2, 2024, 9:15 AM David Hewitt @.***> wrote:

I think that's just it, I see you solved the Path complication above 👍

The eager expansion / unlimited forms of use imports can be problems for the future.

— Reply to this email directly, view it on GitHub https://github.com/PyO3/pyo3/pull/4288#issuecomment-2203129364, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAGBGKNVKA5AIDT53ZPC3ZKKRWPAVCNFSM6AAAAABJ5BGK2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBTGEZDSMZWGQ . You are receiving this because you authored the thread.Message ID: @.***>

alex commented 10 hours ago

Ok, added!