search

PyO3 / pyo3

Rust bindings for the Python interpreter
https://pyo3.rs
Other
11.44k stars 693 forks source link

Avoid generating functions that are only ever const evaluated with declarative modules #4297

Closed alex closed 1 day ago

alex commented 5 days ago

Refs #4286

alex commented 1 day ago

This should be entirely internal, with coverage being the only effect. Do you just want the news fragment to be about coverage?

On Mon, Jul 1, 2024, 10:18 AM David Hewitt @.***> wrote:

@.**** approved this pull request.

Thanks, let's add a newsfragment (maybe either changed or fixed) and merge this 👍

— Reply to this email directly, view it on GitHub https://github.com/PyO3/pyo3/pull/4297#pullrequestreview-2151522708, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAGBE32UJ4HEYHFSJC2QDZKFQKNAVCNFSM6AAAAABJ7ZTAY2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNJRGUZDENZQHA . You are receiving this because you authored the thread.Message ID: @.***>

davidhewitt commented 1 day ago

Yes exactly - maybe "fixed uncoverable region in declarative modules"?