search

PyO3 / pyo3

Rust bindings for the Python interpreter
https://pyo3.rs
Apache License 2.0
12.06k stars 744 forks source link

ci: swap .python-version file for explicit versions in actions yml #4462

Closed davidhewitt closed 1 month ago

davidhewitt commented 1 month ago

This PR removes the .python-version file in the repo root and adds explicit versions to CI YAML.

This is for two reasons:

  1. I was discussing this change with @ngoldbaum anyway, as the .python-version can mess with pyenv and make it harder to test different Python versions if that's your tool of choice.
  2. The valgrind job has a new failure on CPython 3.12.5 which might be an upstream issue (needs investigating / reporting); by pinning to 3.12.4 in the short term we can unblock CI.
codspeed-hq[bot] commented 1 month ago

CodSpeed Performance Report

Merging #4462 will improve performances by 17.36%

Comparing davidhewitt:python-version-explicit (f1a1f38) with main (43110ef)

Summary

⚡ 1 improvements ✅ 76 untouched benchmarks

Benchmarks breakdown

Benchmark main davidhewitt:python-version-explicit Change
⚡ bytes_new_small 394.4 ns 336.1 ns +17.36%
davidhewitt commented 1 month ago

Will merge immediately to unblock CI.