search

PyO3 / pyo3

Rust bindings for the Python interpreter
https://pyo3.rs
Apache License 2.0
12.39k stars 765 forks source link

`PyObjectInit` should be private (and sealed) #4552

Closed davidhewitt closed 1 month ago

davidhewitt commented 2 months ago

PyObjectInit trait is an implementation detail. We should remove it from the public API. If it's needed in macros, we'll move it inside src/impl_/.

https://github.com/PyO3/pyo3/pull/4518#issuecomment-2348518282

cesarmg1980 commented 1 month ago

Hey @davidhewitt can I give it a look ?

davidhewitt commented 1 month ago

Please go for it; as far as I know nobody is working on this.

Cheukting commented 1 month ago

If this is not done yet, I am happy to follow up

cesarmg1980 commented 1 month ago

I was about to start working on this.

On 10 Oct 2024, at 10:13 AM, Cheuk Ting Ho @.***> wrote:

If this is not done yet, I am happy to follow up

— Reply to this email directly, view it on GitHubhttps://github.com/PyO3/pyo3/issues/4552#issuecomment-2405060912, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJISIOLDC2MTOZSP6JZKCYTZ2Z4RNAVCNFSM6AAAAABOFAJIB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBVGA3DAOJRGI. You are receiving this because you commented.Message ID: @.***>