search

PyO3 / rust-numpy

PyO3-based Rust bindings of the NumPy C-API
BSD 2-Clause "Simplified" License
1.11k stars 106 forks source link

Enable the half feature #336

Closed LucaCappelletti94 closed 2 years ago

LucaCappelletti94 commented 2 years ago

Hello, and thank you for making this crate!

I see that the half crate is supported and that the feature half in the code is sprinkled all around.

Yet, it is not available in the Cargo.toml, is there any reason for this?

Best, Luca

adamreichold commented 2 years ago

You should already be able to enable the integration by specifying a dependency like

numpy = { git = "https://github.com/PyO3/rust-numpy.git", features = ["half"] }

Are there any errors if you do this? (Note that the integration is not yet released on crates.io.)

LucaCappelletti94 commented 2 years ago

Yes, it works! Sorry, I had cloned the repo, and I thought I was loading from the local path, yet I must have CTRL-Z that thing as it was still loading from the crate.

Thanks!