search

PyO3 / rust-numpy

PyO3-based Rust bindings of the NumPy C-API
BSD 2-Clause "Simplified" License
1.11k stars 106 forks source link

RFC: Use Valgrind instead of AddressSanitizer #349

Closed adamreichold closed 2 years ago

adamreichold commented 2 years ago

This avoids the need for instrumentation (e.g. -Zbuild-std) and extends coverage to doctests.

It is somewhat slower, but I think that is a reasonable price to pay for the increased coverage and simpler usage.

davidhewitt commented 2 years ago

Happy to use valgrind, though my first thought is why not both?!

adamreichold commented 2 years ago

Happy to use valgrind, though my first thought is why not both?!

Efficient use of CI resources and reduced scope of maintenance are the first things that come to my mind. (Under the assumption that both tackle the same set of problems and that running AddressSanitizer would only catch things that Valgrind should have caught in the absence of implementation errors.)

davidhewitt commented 2 years ago

Sounds reasonable to make the switch in that case 👍